Skip to content

Commit

Permalink
FLUID-4907: Moved primaryBuilder to a subcomponent
Browse files Browse the repository at this point in the history
Using the primary builder as a subcomponent of builder instead of being used as a grade. This works around the FLUID-5101. Also updated the demo to be initialized in manner more closely aligned with what we'd expect an integrator to use.
  • Loading branch information
jobara committed Jul 31, 2013
1 parent edadd4a commit 472d1ec
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 17 deletions.
21 changes: 14 additions & 7 deletions src/components/uiOptions/js/Builder.js
Expand Up @@ -22,7 +22,7 @@ var fluid_1_5 = fluid_1_5 || {};
fluid.registerNamespace("fluid.uiOptions");

fluid.defaults("fluid.uiOptions.builder", {
gradeNames: ["fluid.eventedComponent", "fluid.uiOptions.primaryBuilder", "fluid.uiOptions.auxBuilder", "autoInit"],
gradeNames: ["fluid.eventedComponent", "fluid.uiOptions.auxBuilder", "autoInit"],
mergePolicy: {
auxSchema: "expandedAuxSchema"
},
Expand Down Expand Up @@ -50,13 +50,20 @@ var fluid_1_5 = fluid_1_5 || {};
args: ["{that}.options.auxSchema", ["enactors", "messages", "panels", "rootModel", "templateLoader", "messageLoader", "templatePrefix", "messagePrefix"]]
}
},
typeFilter: {
expander: {
func: "fluid.uiOptions.builder.parseAuxSchema",
args: "{that}.options.auxiliarySchema"
mappedDefaults: "{primaryBuilder}.options.schema.properties",
components: {
primaryBuilder: {
type: "fluid.uiOptions.primaryBuilder",
options: {
typeFilter: {
expander: {
func: "fluid.uiOptions.builder.parseAuxSchema",
args: "{builder}.options.auxiliarySchema"
}
},
}
}
},
mappedDefaults: "{that}.options.schema.properties"
}

});

Expand Down
12 changes: 2 additions & 10 deletions src/demos/uiOptions/js/uiOptionsDemo.js
Expand Up @@ -20,17 +20,9 @@ var demo = demo || {};
(function ($, fluid) {

demo.initFatPanel = function (container) {
// var builder = fluid.uiOptions.builder({
// gradeNames: ["fluid.uiOptions.auxSchema.starter"]
// });
// fluid.invokeGlobalFunction(builder.options.assembledUIOGrade, [".flc-uiOptions-fatPanel"]);

// work around for FLUID- 5105
fluid.defaults("demo.uiOptions.builder", {
gradeNames: ["fluid.uiOptions.auxSchema.starter", "fluid.uiOptions.builder", "autoInit"]
var builder = fluid.uiOptions.builder({
gradeNames: ["fluid.uiOptions.auxSchema.starter"]
});
var builder = demo.uiOptions.builder();
demo.builder = builder;
fluid.invokeGlobalFunction(builder.options.assembledUIOGrade, [".flc-uiOptions-fatPanel"]);
};

Expand Down

0 comments on commit 472d1ec

Please sign in to comment.