New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLUID-4698: setting font-size on html #497
Conversation
Modified the textSize enactor to set the font-size on the root element (html) instead of the container (body). This will allow support of rem units. Another change with this was to set the value in px instead of ems. This is necessary since the root element has no parent for which to base it's value on. The unit tests have been updated.
There's an issue with this pull request:
|
@jobara, another issue is the change on the font size is not applied to the UIO panel when you close and re-open it. The change is applied to the main page correctly. |
Fixed an issue where the text size would always be set on the parent document. This was causing issues with the separated panel which uses an iframe for the controls and has its own enactors. Also made another small modification that ensures the multiplier used is always a legitimate value.
Enactors-test.html and UIEnhancer-test.html fail in IE (tried with IE8 & 9) but not other browsers. In the master branch, Enactors-test.html already fails with UIEnhancer-test.html passes. Perhaps an opportunity to fix Enactors test too. |
@cindyli I tested in IE 8, 9, 10, & 11. I've filed a new jira for the enactor failure for lineSpace http://issues.fluidproject.org/browse/FLUID-5320 I wasn't able to reproduce the failing tests for UIEnhancer. In IE 8 I also had a failure for the builder tests but they seemed to be related to jqUnit not being created properly. I'm not sure why this is happening though. |
We can address the builder failure in IE8 in another jira since it happens for the master branch too. I've filed a jira for it: http://issues.fluidproject.org/browse/FLUID-5323 In terms of the UIEnhancer failure, I cannot reproduce it with sauceLabs environment too. It might be something specific in my local VM. |
Merged into the project repo @ c7c61c4 |
Modified the textSize enactor to set the font-size on the root element (html) instead of the container (body). This will allow support of rem units. Another change with this was to set the value in px instead of ems. This is necessary since the root element has no parent for which to base it's value on. The unit tests have been updated.
http://issues.fluidproject.org/browse/FLUID-4698