This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
SJRK-374: solved issue of empty video element being focusable in Firefox #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobara
reviewed
Jul 14, 2020
themes/base/css/storyTelling.css
Outdated
| background: url(../img/icons/Video-background.svg) center center no-repeat; | ||
| } | ||
|
|
||
| video:not([controls]) { | ||
| display: none; | ||
| height: 0; |
There was a problem hiding this comment.
Is height required here? display: none; should remove the element visually, layout spacing, and from the a11y tree.
There was a problem hiding this comment.
This is a good point. I'd left it in there as this is what Normalize does with audio elements, but since this rule isn't even present in Normalize after 7.x, I've removed the height specification and added an audio:not([controls]) selector to this rule, to ensure it continues to work as expected if and when we update Normalize
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.