Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

STUDIO-53: Fixed some UI issues on the archive pages. #48

Merged
merged 7 commits into from Jun 28, 2012
Merged

STUDIO-53: Fixed some UI issues on the archive pages. #48

merged 7 commits into from Jun 28, 2012

Conversation

abledaccess
Copy link
Contributor

OK, should be good to go. Let me know.

@jobara
Copy link
Member

jobara commented Jun 26, 2012

@abledaccess I looked this over with @cindyli again today. Thanks, it looks good. You seemed to have fixed those issues. However, we did notice that you've introduced at least one new !important. Could you re-examine all the cases where you've used !important to see if they are really necessary. It would be preferable to minimize there occurrences.

…to be doing nothing in the IE8 styles and resolved a slight shift in that same button on the archive pages also in IE8.
…emoved in my last fix seems to have persisted so I resolved it though specificity rather than use an !important.
@abledaccess
Copy link
Contributor Author

Justin, my issues with Windows seems to have been resolved (mostly) and I took out that !important out, but I had to resolve the original collapsing button issue through specificity. But we're good now.

@jobara
Copy link
Member

jobara commented Jun 27, 2012

@abledaccess thanks for all the changes. 2 more issues came up in our latest round of testing. 1) this is similar to something you've fixed before. The bullets for the ToC on the single pages, when a contrast theme is applied, is on the wrong line. Bottom instead of top, when the text wraps. 2) The text for the "Show Preferences" button is too long for it's container when the "Verdana" font is selected. Only in IE 7.

@abledaccess
Copy link
Contributor Author

Justin, I can't get the ToC bullet issue to reproduce, in Firefox or Safari. I suspect it happens in a modern browser cos the window can't shrink narrow enough to affect the ToCs links. What am I missing? And I bumped the show preferences button'ss width a bit. I'll await word on the former issue before committing. Thanks.

…7 and a ToC list button issue on single pages in the individual UIO colour themes.
…ecific areas on the page so linked images receive focus all the way around the images in Webkit.
@cindyli cindyli merged commit 79243af into fluid-project:development Jun 28, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants