feat: add JS processing (resolves #28) #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobara
reviewed
Sep 30, 2020
jobara
reviewed
Sep 30, 2020
jobara
reviewed
Sep 30, 2020
jobara
reviewed
Sep 30, 2020
|
@greatislander it looks like the standard eslint-config-fluid is being used, but I see that some of the JS files have at least some instances that appear to be using 2 spaces instead of 4. Does this pass linting and/or is it configured properly? |
jobara
reviewed
Oct 14, 2020
jobara
reviewed
Oct 14, 2020
jobara
reviewed
Oct 14, 2020
|
merged at f5ec52e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes an alternative approach to #28 based on http://github.com/clenemt/eleventy-webpack, necessitated by the fact that fluidic-11ty has two JavaScript entry files. This configuration allows any number of JavaScript entry files to be processed with Webpack and Babel, and triggers live reloads of Eleventy when in dev mode by updating a Nunjucks template partial which includes hashed links to the generated JavaScript output files.