Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gcode Preview doesn't reset #659

Closed
Arakon opened this issue May 7, 2022 · 0 comments · Fixed by #683
Closed

Gcode Preview doesn't reset #659

Arakon opened this issue May 7, 2022 · 0 comments · Fixed by #683
Labels
FR - Enhancement New feature or request
Milestone
1.18.1

Comments

@Arakon
Copy link

Arakon commented May 7, 2022

Is your feature request related to a problem? Please describe

Kinda, more of a QOL improvement.

When starting a print and selecting "Load current file" and "Follow progress" in the gcode preview, it will show the current print fine.
However, if you i.e. abort the print and instead print a different file, it will still load and show progress of the previous file.. so if you print a triangle, abort, and start the print of a square, the gcode preview will show the triangle being printed.

Describe the solution you'd like

At the very least, when aborting a print, it should unload the file from gcode preview, or automatically load the new file.

Describe alternatives you've considered

No response

Additional information

No response
@Arakon Arakon added the FR - Enhancement New feature or request label May 7, 2022
@matmen matmen added this to the 1.19 milestone May 9, 2022
@pedrolamas pedrolamas modified the milestones: 1.19, 1.18.1 May 18, 2022
pedrolamas added a commit to pedrolamas/fluidd that referenced this issue May 18, 2022
@pedrolamas
fix: clear "follow progress" if not correct file printing
7aa35e7 
Fixes fluidd-core#659

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas mentioned this issue May 18, 2022
Merged
pedrolamas added a commit that referenced this issue May 18, 2022
@pedrolamas
fix: clear "follow progress" if not correct file printing (#683)
21892ca 
Fixes #659

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
matmen pushed a commit to matmen/fluidd that referenced this issue Jun 27, 2022
@pedrolamas @matmen
fix: clear "follow progress" if not correct file printing (fluidd-cor…
f5f25c8 
…e#683)

Fixes fluidd-core#659

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@e3palma e3palma mentioned this issue Oct 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FR - Enhancement New feature or request
Projects
None yet
Milestone
1.18.1
Development

Successfully merging a pull request may close this issue.

fix: clear "follow progress" if not correct file printing pedrolamas/fluidd
3 participants
@pedrolamas @Arakon @matmen