feat: Pressure Advance per extruder stepper #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
added
GH - Bug
matmen
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Pressure Advance controls work fine when there is an
[extruder]with a stepper attached, but when we have them separately (by using[extruder_stepper]entries), this would just not work as there is no "active extruder stepper" entity)To fix this, we will now show the existing PA controls for active extruder if it has a stepper attached, and a new separate box with PA controls for each of the separate extruder steppers.
These boxes are collapsible and by default they will load in collapsed state:
(Note: one can easily test this with a Docker container running docker-klipper-simulavr, just set the correct "dual stepper extruder" in the printer.cfg)
Fixes #681
Signed-off-by: Pedro Lamas pedrolamas@gmail.com