Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: live printing bed mesh changes #1056

Merged
merged 4 commits into from Mar 5, 2023

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Mar 4, 2023

This a considerable refactor of Bed Mesh in Fluidd and will need further testing, but brings the following major changes:

  • Bed mesh profiles are now retrieved from printer.bed_mesh.profiles object instead of config settings (reason being that this object is "live" updated, but the config never changes)
  • Bed mesh profiles can be loaded/cleared/changed while printer is printing (I see no reason to not allow this if Klipper allows for it), calibration and homing will still be disabled if printer is busy.
  • Bed mesh save/delete will NOT restart the printer (it will instead show the "SAVE CONFIG AND RESTART" button on top and wait for user confirmation - all translations have been updated accordingly!

Note: this might be easier to review with "hide whitespace" option enabled!

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added FR - Enhancement New feature or request Code - Optimizations Everything that relates to code optimizations! labels Mar 4, 2023
@pedrolamas pedrolamas added this to the 1.24 milestone Mar 4, 2023
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but are the buttons (clear profile, delete profile) enabled while printing intentionally now? Not sure what the side effects of deleting a profile while printing would be..

src/components/widgets/bedmesh/BedMeshControls.vue Outdated Show resolved Hide resolved
@pedrolamas
Copy link
Member Author

All good points, I've been giving some though on this for the last couple of days!

Starting on delete, once a bed mesh is loaded into memory, the profile can be deleted and the mesh data will remain in memory, so deleting a profile while printing has zero impact on the active print.

Now loading or clearing a profile while printing will impact the active print. I agree that a simple click as it currently is might not be appropriate... so maybe show a confirmation message for clear/load if state printing?

@pedrolamas
Copy link
Member Author

I've now added confirmation dialogs for mesh load/clear if printer printing (no confirmation dialog is shown if printer is paused, I see no reason for that as there is no big impact anyway).

image

Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedrolamas pedrolamas merged commit e88e783 into fluidd-core:develop Mar 5, 2023
@pedrolamas pedrolamas deleted the pedrolamas/live-bed-mesh branch March 5, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code - Optimizations Everything that relates to code optimizations! FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants