Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic Nevermore Controller support #1114

Merged
merged 7 commits into from
Mar 20, 2024

Conversation

SanaaHamel
Copy link
Contributor

@SanaaHamel SanaaHamel commented Jun 23, 2023

Add support for Nevermore Controller sensors. Sadly due to how Fluidd reads data, I can't fake it by pretending to be a bme280.

Signed-off-by: Sanaa Hamel sanaahamel@outlook.com

@pedrolamas
Copy link
Member

Thanks @SanaaHamel for this PR.

I will keep this in mind and see if there is something we can improve on this area to make it more "dynamic", but I must admit I am not comfortable adding support for ad-hoc sensors that are not supported by mainline Klipper.

@SanaaHamel
Copy link
Contributor Author

I'd prefer a more flexible solution as well, but don't really have the time to dedicate to it. Mainsail has the same issue, but I can manage it there using shenanigans with sensor's qualified object name. Fluidd is more pedantic (doesn't use the full object name when selecting sensor-like objects, and gives up if the sensor object prefix doesn't match the declared sensor kind).

Ideally I'd like to be able to declare compound sensor sources (temp, pressure, etc), as well as plot non-temperature data. I expect that would take some changes in Klipper, however.

The proposed changes caused a miss in the printer state on line 709
@pedrolamas pedrolamas changed the title Nevermore Controller Support feat: basic Nevermore Controller support Mar 20, 2024
@pedrolamas pedrolamas requested a review from matmen March 20, 2024 17:00
@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Mar 20, 2024
@pedrolamas pedrolamas added this to the 1.29.1 milestone Mar 20, 2024
@pedrolamas
Copy link
Member

We have been revisiting some of these feature requests as we have been adding support to non-mainline Klipper modules for a while.

Given this, I have reviewed and approved the changes on this Pull Request.

Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@matmen matmen merged commit 91ee7d5 into fluidd-core:develop Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants