Element Ready #39
Merged
Element Ready #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borosr
requested changes
May 5, 2022
| newChild.id = 'latediv' | ||
| setTimeout(() => { | ||
| main.appendChild(newChild) | ||
| }, 100) |
There was a problem hiding this comment.
I tested with 10000ms delay and got the following error on the console:
index.ts?144e:87 Uncaught Error: Could not find container
at eval (index.ts?144e:87:1)
at eval (index.ts?144e:186:1)
There was a problem hiding this comment.
Thats a good catch. But its intentional. It will stop attempting to look for the container after 10,000ms. Otherwise it would just keep looking. I figured if tokenizer is still looking for a container after 10,000ms the container doesnt exist.
There was a problem hiding this comment.
Okay, that make sense, thanks for the answer!
borosr
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving the issue of the element not ready yet for when people have the script in the header