Fix bug where opts = { seqs: true }
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code that took care of filtering out deleted items (empty
buffers) just checked whether the item was an empty buffer, but that
doesn't account for the case where `{ seqs: true }` and the value is
actually exposed in `{ value }`.
|
Looks good to me @christianbundy, nice with the test! I'll have a look at the other changes as well, eager to test some of this stuff. |
|
Sweet, thanks for the quick review! Btw, I know I've been super liberal with tagging you for review requests, please feel free to ping me if you'd like any 👀 on your stuff. 👍 |
|
I enjoy reading these flume patches, but can't take in any patchwork @christianbundy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code that took care of filtering out deleted items (empty
buffers) just checked whether the item was an empty buffer, but that
doesn't account for the case where
{ seqs: true }and the value isactually exposed in
{ value }.Resolves #18