EcdsaSecp256k1RecoverySignature2020 for commit credentials #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just the jvm implementation, cljs is a bit thornier.
The jld-processor/canonize function has differing calling conventions for cljs and clj - in cljs it returns a promise, in clj it is synchronous. This wraps the calls in an core async go block and reads the promise with the handy <p! macro. As a note, our signature generation produces different signatures on cljs and clj, but they are mutually readable. The tests verify that. See this issue for the details: fluree/fluree.crypto#20 Fixes #245
Accidentally wrapped the ex-info info in the `str` call.
https://jestjs.io/docs/ecmascript-modules It was failing without this.
bplatz
approved these changes
Nov 30, 2022
|
The library adds about 112KB to the optimized package size, so it's pretty substantial. I took a stab last week at implementing the subset of the api that we would need to canonicalize our own documents (so, not fully compliant with the entire suite but producing the same output for our needs). If I can finish that up we should be able to ditch this. Still though, the entire package size is dominated by the static contexts and vocabs: those weigh in at about 3.74MB, so if we can figure out a clever way to deal with that we're a lot better off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245