Expand policy opts role using supplied context #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cap10morgan
approved these changes
Nov 20, 2023
test/fluree/db/policy/basic_test.clj
Outdated
| @(fluree/query-connection conn | ||
| {:context context | ||
| :from "policy/a" | ||
| :select '[?name ?ssn] |
There was a problem hiding this comment.
"policy/a" is misaligned w/r/t the other map vals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fluree/core#61
Up to now, the
wrap-policyprocess has relied entirely on default context to expand the iri of the provided:roleand look up its subject id. The call it has been making tosubidhas a default behavior that expands using the db's default context.This PR updates our policy opts helper (renamed to
policy-identity) to expand the iri itself when given a context. Also updates our api fns to pass the supplied context from the request to that helper fn.I removed the use of default context from a large number of the policy tests, but not all of them.
I did not want to mess with removing any existing default context logic yet (and have to change many unrelated tests), so there's some redundancy here. I have introduced a context helper that just pulls out the supplied context from the request map, with no interaction with the default context whatsoever. I just use this when processing opts, leaving existing context retrieval/calculation processes (which do use default context) intact.