Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #790 from fluree/feature/policy-query2" #806

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zonotope
Copy link
Contributor

The policy-query2 branch causes test to fail when integrated with fluree/server. This patch reverts this branch temporarily to allow us to continue to create working server images while identifying and fixing the test failures.

This reverts commit f942330, reversing changes made to 8f1f988.

This reverts commit f942330, reversing
changes made to 8f1f988.
@zonotope zonotope requested a review from a team June 16, 2024 16:11
@bplatz
Copy link
Contributor

bplatz commented Jun 17, 2024

There are some tests on fluree/server that transact f:equals data and tries policy around them, and that older policy mechanism is deprecated. Those tests need to be modified so they use the new policy query... but in the interim they can also be removed as they are not intended to work.

I'll get some new tests in fluree/server to replace them that use the new policy framework.

@zonotope
Copy link
Contributor Author

There are some tests on fluree/server that transact f:equals data and tries policy around them, and that older policy mechanism is deprecated. Those tests need to be modified so they use the new policy query... but in the interim they can also be removed as they are not intended to work.

I'll get some new tests in fluree/server to replace them that use the new policy framework.

That works. We don't have to merge this branch if we know what's going on. I mainly needed to get a new image with some recent bug fixes out so I needed something to build off of that both passed ci and had the bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants