Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui)!: provide magnifier configuration parameter to form builder text field #1185

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

tsinis
Copy link
Contributor

@tsinis tsinis commented Feb 16, 2023

Connection with issue(s)

Connected to Flutter SDK bug: flutter/flutter#119711

Solution description

In version 3.7 Flutter team introduced Text magnifier feature, however, did not provide a way how to disable it globally. But this feature has bugs related to scrollable widgets. As a workaround, there is an option to provide magnifierConfiguration to TextField/EditableText widgets. Since FormBuilderTextField is using TextField under the hood there was no way how to provide this configuration to FormBuilderTextField, this PR fixes this issue.

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • If apply, add documentation to code properties and package readme

@tsinis
Copy link
Contributor Author

tsinis commented Feb 16, 2023

Failing on "info"s, at analyze part, however, contributing guide mentioning warnings/errors only :-/. I will try if it's possible to fix it without any big harm or breaking changes tomorrow.

@deandreamatias
Copy link
Collaborator

Hi @tsinis
Thanks for contribution. I changed the contribution file, but witch you said is true, the document only refer to warning and errors. But, if you can fix this info lints, will be a nice contribution (one more) to package. I will really appreciate that

@tsinis
Copy link
Contributor Author

tsinis commented Feb 17, 2023

Hi @tsinis Thanks for contribution. I changed the contribution file, but witch you said is true, the document only refer to warning and errors. But, if you can fix this info lints, will be a nice contribution (one more) to package. I will really appreciate that

Hey, @deandreamatias I've fixed the infos (replaced the deprecated field with a new one). By the way, you should add the pubspec.lock file to the .gitignore, this is not a file that should be committed to the package: https://dart.dev/guides/libraries/private-files#pubspeclock

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1185 (f2b71bc) into main (9742864) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   83.99%   83.99%           
=======================================
  Files          19       19           
  Lines         706      706           
=======================================
  Hits          593      593           
  Misses        113      113           
Impacted Files Coverage Δ
lib/src/fields/form_builder_text_field.dart 95.12% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 8296f60 into flutter-form-builder-ecosystem:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants