Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows support #1198

Merged

Conversation

yfakariya
Copy link
Contributor

@yfakariya yfakariya commented Mar 6, 2023

Connection with issue(s)

Connected to #350

Solution description

Add files of examples on patterns of #1097. I confirmed basic behaviors of examples.

My environment is:

  • Windows 11 Pro, 10.0.22621.1265
  • Visual Studio Community 2022 17.5.1 (to build windows app)
  • flutter --version
Flutter 3.7.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 12cb4eb7a0 (4 days ago) • 2023-03-01 10:29:26 -0800
Engine • revision ada363ee93
Tools • Dart 2.19.3 • DevTools 2.20.1

Screenshots or Videos

form_builder_screenshot_windows

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #1198 (4d587ba) into main (4c83c5c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1198   +/-   ##
=======================================
  Coverage   83.99%   83.99%           
=======================================
  Files          19       19           
  Lines         706      706           
=======================================
  Hits          593      593           
  Misses        113      113           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 3e3627b into flutter-form-builder-ecosystem:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants