Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve skip disabled feature #1225

Merged
merged 1 commit into from
Apr 22, 2023
Merged

fix: improve skip disabled feature #1225

merged 1 commit into from
Apr 22, 2023

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented Apr 22, 2023

Connection with issue(s)

Close #957

Solution description

Now when skip disabled is set to true, do not show the error on field decoration

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #1225 (368fb8d) into main (c88535d) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
+ Coverage   83.66%   83.87%   +0.20%     
==========================================
  Files          19       19              
  Lines         710      713       +3     
==========================================
+ Hits          594      598       +4     
+ Misses        116      115       -1     
Impacted Files Coverage Δ
lib/src/form_builder.dart 70.93% <ø> (+1.16%) ⬆️
lib/src/form_builder_field.dart 79.76% <100.00%> (+0.74%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 37d91c4 into main Apr 22, 2023
4 of 5 checks passed
@deandreamatias deandreamatias deleted the fix-skip-disabled branch April 22, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skipDisabled doesn't really skip
1 participant