Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary rebuild on Form #1235

Merged
merged 2 commits into from
May 3, 2023
Merged

Avoid unnecessary rebuild on Form #1235

merged 2 commits into from
May 3, 2023

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented May 3, 2023

Connection with issue(s)

Close #1129

Solution description

Add a InheritedWidget to improve when FormBuilder rebuild widgets.
Now only rebuild widgets that receive changes

Inspired by fast-forms (thanks @udos86) and by reactive_forms

Screenshots or Videos

Screen.Recording.2023-05-03.at.10.27.58.mov

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1235 (418d79f) into main (52fbc62) will decrease coverage by 0.32%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
- Coverage   86.09%   85.77%   -0.32%     
==========================================
  Files          20       20              
  Lines         719      724       +5     
==========================================
+ Hits          619      621       +2     
- Misses        100      103       +3     
Impacted Files Coverage Δ
lib/src/form_builder.dart 75.28% <62.50%> (-2.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit e1b1d7f into main May 3, 2023
3 of 5 checks passed
@deandreamatias deandreamatias deleted the improvement-1129 branch May 3, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve re-building when change single field (that don't be affect to entire form)
1 participant