Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onTapOutside to FormBuilderTextField #1267

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

AlvBarros
Copy link
Contributor

Let me know if there's anything else that needs to be done, or if the solution needs to be fixed in any way.

Connection with issue(s)

Close #1266

Solution description

Simply create a new property TapRegionCallback? onTapOutside, add it to the constructor and then pass it down to the widget.

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@deandreamatias
Copy link
Collaborator

Thanks for.your contribution
Please format code to pass pipeline

@AlvBarros
Copy link
Contributor Author

So I've ran the other steps in the base.yaml in my machine, and everything seems great. I'll pay attention if any other error comes up.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1267 (4498e6d) into main (edcebe5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1267   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files          20       20           
  Lines         705      705           
=======================================
  Hits          599      599           
  Misses        106      106           
Impacted Files Coverage Δ
lib/src/fields/form_builder_text_field.dart 90.69% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 079d25a into flutter-form-builder-ecosystem:main Jun 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormBuilderTextField]: Please add onTapOutside function to make keyboard dismiss if click outside
2 participants