Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormBuilderRangeSlider: Correct internal values when min/max changes #1331

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

velten-dev
Copy link

Connection with issue(s)

Close #1330
Close #1305

Solution description

Implemented solution described in #1330. TLDR: performed check to make sure that the current range is reset if it is out of bounds due to a change in the min/max of the slider range. Corrected logic when no initial value was specified and corrected unit tests to fail when the regression is readded (tests were missing pump of the tester). Added unit test and corrected a failed test due to incorrect selector.

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8038db6) 85.00% compared to head (217cf8f) 85.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   85.00%   85.14%   +0.14%     
==========================================
  Files          21       21              
  Lines         727      734       +7     
==========================================
+ Hits          618      625       +7     
  Misses        109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deandreamatias deandreamatias merged commit b020e8d into flutter-form-builder-ecosystem:main Nov 28, 2023
5 checks passed
@deandreamatias
Copy link
Collaborator

Thanks a lot for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants