fix: #1388 Respect latest field's initial value (esp when its forcefully recreated)

[nvshah]

TASK #1388

Connection with issue(s)

Solution description

Always respect latest field's initial value rather than assigning old field's value (if present)

Screenshots or Videos

To Do

• Read contributing guide
• Check the original issue to confirm it is fully satisfied
• Add solution description to help guide reviewers
• Add unit test to verify new or fixed behaviour
• If apply, add documentation to code properties and package readme

[deandreamatias]

Hi! Thanks for contribution!

I updated the build to run with flutter 3.22.
This changes do not pass on test, so is a breaking change compared with current behavior.

Take a look if can change the solution or have some way to pass tests without delete them

[kris175]

Hi, I doubt whether this is the actual root cause or not.

I was able to temporarily fix this issue where the initial value is not being assigned upon reset by reverting to the version 7 which has the same code that is being replaced in this PR, but not in shorthand form.

if (oldField != null) {
      // ignore: invalid_use_of_protected_member
      field.setValue(oldField.value, populateForm: false);
    } else {
      // ignore: invalid_use_of_protected_member
      field.setValue(
        _instantValue[name] ??= field.initialValue,
        populateForm: false,
      );
    }

Therefore it leads me to think it's some other change which is causing this issue and not because of this specific piece of code being changed in the PR.

I will try to compare changes and update if I get time.

[nvshah]

Updated the PR @deandreamatias

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (2771019) to head (8ad740f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
+ Coverage   87.85%   87.89%   +0.03%     
==========================================
  Files          21       21              
  Lines         766      768       +2     
==========================================
+ Hits          673      675       +2     
  Misses         93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.