Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1396 fix dynamic fields example widget issues #1397

Merged

Conversation

ArturAssisComp
Copy link
Contributor

Connection with issue(s)

Close #1396

Connected to #???

Solution description

Handle the list of text fields in such a way that each element is deleted based on its unique local key, not based on the size of the list.

Screenshots or Videos

pr-demo.mp4

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@ArturAssisComp
Copy link
Contributor Author

I did not add unit tests because there is no unit tests in the folder example. But, if you want, I can add.

@deandreamatias deandreamatias changed the title #1396 fix dynamic fields example widget issues fix: #1396 fix dynamic fields example widget issues May 24, 2024
@deandreamatias
Copy link
Collaborator

Thanks for your contribution!

@deandreamatias deandreamatias merged commit bd58dda into flutter-form-builder-ecosystem:main May 24, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[General]: Field deletion in the dynamic form example is not working properly.
2 participants