Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fully custom preview #54

Conversation

mvarendorff
Copy link
Contributor

Connection with issue(s)

Connected to #6 and #48

Solution description

This PR adds a new property to FormBuilderImagePicker that allows a custom layout for the preview. This creates an escape hatch for many problems like:

Screenshots or Videos

This for example is a custom preview that uses GridView.extent to lay the selected images out in a grid:

grafik

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@deandreamatias
Copy link
Contributor

Nice contribution! Thanks for that

@deandreamatias deandreamatias merged commit 250214c into flutter-form-builder-ecosystem:main Oct 12, 2023
3 checks passed
@mvarendorff mvarendorff deleted the feat/preview-builder branch October 12, 2023 10:43
@mvarendorff mvarendorff restored the feat/preview-builder branch October 16, 2023 06:08
@mvarendorff
Copy link
Contributor Author

@deandreamatias Is there a chance you could release a new version with this included? While I can just run the fork, they often get forgotten and for updates need to be rebased, etc. which is quite tedious and prone to error :/

@mvarendorff mvarendorff deleted the feat/preview-builder branch December 8, 2023 11:45
@mvarendorff mvarendorff restored the feat/preview-builder branch December 8, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants