Improved Image Source Support #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add const keyword to LatLngQuad so that is can be instantiated as a constant in consuming projects.
Rename the parameters in the controller to make it more explicit which id you are passing along (source or layer). Improve the PlaceSource example by using static source & layer ids which should help to make it more obvious what you are dealing with (source vs layer).
Instead of having parameters called name when communicating with the native world. Use imageLayerId & imageSourceId to make it more explicit what we are dealing with.
Support adding layers below other layers for more fine-grained control as to where your image source ends up.
tobrun
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR for adding basic image source support got merged, and while functional, I think it was lacking some consistency. This PR is a continuation of that work, it:
nameit's now eitherimageSourceIdorimageLayerId.addLayerBelowfunctionality. In my use case I had to insert layers below the markers, this can be done using this functions and e.g. adding the source below thecountry-labellayer.PlaceSourcesample to more clearly demonstrate the difference between the ImageSource and ImageLayer and to add a demo of theaddLayerBelowfunctionality.note: it's built on top of the UnsatisfiedLinkError branch as without those changes I could not get the sample project to run anymore.
addLayerBelowdemo: