fixed layer based feature selection #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-ht
changed the title
felix-ht
changed the title
Can you try doing it yourself? Updated the permissions :) |
AAverin
reviewed
Nov 16, 2021
@tobrun worked fine, thanks for setting this up 👍 |
AAverin
approved these changes
Nov 16, 2021
AAverin
reviewed
Nov 16, 2021
AAverin
approved these changes
Nov 17, 2021
tobrun
approved these changes
Nov 17, 2021
cheers-group
added a commit
to cheers-group/flutter-mapbox-gl
that referenced
this pull request
Nov 18, 2021
fixed layer based feature selection (flutter-mapbox-gl#765)
cheers-group
added a commit
to cheers-group/flutter-mapbox-gl
that referenced
this pull request
Nov 18, 2021
This reverts commit b26debb.
m0nac0
added a commit
to maplibre/flutter-maplibre-gl
that referenced
this pull request
May 14, 2022
flutter-mapbox-gl/maps#765 Co-authored-by: Felix Horvat <24698503+felix-ht@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
"feature#onTap"method channel returns a random feature visible feature at the current location. So it ignores the order of the layers.This is caused by
visibleFeaturesstrange ios implementation (as opposed to android and web).To fix this i added a function that gets the actual order of the user added layers as shown on the map, and then queries
visibleFeaturesin order until it finds a feature. This is somewhat slower than the old solution (~2ms instead of ~1ms at 40 layers), and might get worse with more layers, but seems to be the only solution i could come up with.