fixed LocationTracking issue delayed permissions #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-ht
force-pushed
the
fixed-LocationTrackingMode-not-working-with-delayed-permissions
branch
from
8fdb5e3
to
bd28c48
Compare
Chaoba
reviewed
Mar 23, 2022
AAverin
approved these changes
Mar 24, 2022
|
Does this resolve? |
felix-ht
deleted the
fixed-LocationTrackingMode-not-working-with-delayed-permissions
branch
unlikely - when do you get this error? |
|
@felix-ht Seems to happen if I decline location permissions. |
|
@AAverin this is quite strange as the locationComponent should be null if there are no permissions. |
|
try this diff @AAverin diff --git a/android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java b/android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
index 4a352bc..96a9fe4 100644
--- a/android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
+++ b/android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
@@ -281,8 +281,8 @@ final class MapboxMapController
}
}
- private void updateLocationLocationComponentLayer() {
- if (locationComponent != null && style != null) {
+ private void updateLocationComponentLayer() {
+ if (locationComponent != null && style != null && hasLocationPermission()) {
locationComponent.applyStyle(buildLocationComponentOptions(style));
}
}
@@ -822,7 +822,7 @@ final class MapboxMapController
properties,
enableInteraction,
null);
- updateLocationLocationComponentLayer();
+ updateLocationComponentLayer();
result.success(null);
break;
@@ -848,7 +848,7 @@ final class MapboxMapController
properties,
enableInteraction,
null);
- updateLocationLocationComponentLayer();
+ updateLocationComponentLayer();
result.success(null);
break;
@@ -874,7 +874,7 @@ final class MapboxMapController
properties,
enableInteraction,
null);
- updateLocationLocationComponentLayer();
+ updateLocationComponentLayer();
result.success(null);
break;
@@ -900,7 +900,7 @@ final class MapboxMapController
properties,
enableInteraction,
null);
- updateLocationLocationComponentLayer();
+ updateLocationComponentLayer();
result.success(null);
break;
@@ -922,7 +922,7 @@ final class MapboxMapController
belowLayerId,
properties,
null);
- updateLocationLocationComponentLayer();
+ updateLocationComponentLayer();
result.success(null);
break;
@@ -944,7 +944,7 @@ final class MapboxMapController
belowLayerId,
properties,
null);
- updateLocationLocationComponentLayer();
+ updateLocationComponentLayer();
result.success(null);
break;
|
|
I have now updated to latest master and issue is still there: #968 |
FreeGrow
added a commit
to FreeGrow/maps
that referenced
this pull request
Sep 21, 2023
…box-gl#958)" This reverts commit 17a701f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On android if the users starts up the app for the first time it has no permissions to track the user location. Even if the the location tracking mode is later changed the location puck would not show because the locationComponent does not come up.
This PR fixes that by activating the locationComponent on a mode change if it hasn’t already been activated.