fix: collectBankAccount returns PlatformException(Invalid Params) #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for initial feedback |
jonasbark
reviewed
Dec 1, 2023
| required String clientSecret, | ||
| required CollectBankAccountParams params, | ||
| }) async { | ||
| final result = await _methodChannel | ||
| .invokeMapMethod<String, dynamic>('collectBankAccount', { | ||
| 'isPaymentIntent': isPaymentIntent, | ||
| 'intentType': true, |
There was a problem hiding this comment.
I think isPaymentIntent should remain and is a bit clearer than "intentType"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1467
Refactor
collectBankAccountto resolve the issue.Changed
isPaymentIntenttointentTypeandBillingDetailstoPaymentMethodData.The methodChannel invokes
collectBankAccountwhich shows the Stripe sheet, but due to above issues the problems was occuring which is reported in #1467 .The generated code is created using
flutter pub run build_runner build --delete-conflicting-outputs, note that the new generated files now has a different way of creating classes.