Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[permission_handler] Support Tizen 4.0 #139

Merged
merged 2 commits into from Jul 5, 2021
Merged

[permission_handler] Support Tizen 4.0 #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac57ffa
[permission_handler] Support Tizen 4.0
bbrto21 Jun 28, 2021
2dc3b7b
[permission_handler] Update based on review
bbrto21 Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/permission_handler/example/tizen/tizen-manifest.xml
View file
Open in desktop
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="org.tizen.permission_handler_tizen_example" version="1.0.0" api-version="5.5" xmlns="http://tizen.org/ns/packages">
<manifest package="org.tizen.permission_handler_tizen_example" version="1.0.0" api-version="4.0" xmlns="http://tizen.org/ns/packages">
<profile name="common"/>
<ui-application appid="org.tizen.permission_handler_tizen_example" exec="Runner.dll" type="dotnet" multiple="false" taskmanage="true" nodisplay="false" api-version="4" launch_mode="single">
<label>permission_handler_tizen_example</label>
Expand Down
2 changes: 1 addition & 1 deletion packages/permission_handler/tizen/project_def.prop
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@

APPNAME = permission_handler_tizen_plugin
type = sharedLib
profile = common-5.5
profile = common-4.0

# Source files
USER_SRCS += src/permission_manager.cc src/app_settings_manager.cc src/service_manager.cc src/permission_handler_tizen_plugin.cc
Expand Down
49 changes: 28 additions & 21 deletions packages/permission_handler/tizen/src/permission_handler_tizen_plugin.cc
View file
Open in desktop
Expand Up @@ -9,15 +9,17 @@
#include "permission_manager.h"
#include "service_manager.h"

#define PERMISSION_HANDLER_CHANNEL_NAME \
"flutter.baseflow.com/permissions/methods"
namespace {
constexpr char kPermissionHandlerChannelName[] =
"flutter.baseflow.com/permissions/methods";
}

class PermissionHandlerTizenPlugin : public flutter::Plugin {
public:
static void RegisterWithRegistrar(flutter::PluginRegistrar *registrar) {
auto channel =
std::make_unique<flutter::MethodChannel<flutter::EncodableValue>>(
registrar->messenger(), PERMISSION_HANDLER_CHANNEL_NAME,
registrar->messenger(), kPermissionHandlerChannelName,
&flutter::StandardMethodCodec::GetInstance());

auto plugin = std::make_unique<PermissionHandlerTizenPlugin>();
Expand Down Expand Up @@ -46,16 +48,17 @@ class PermissionHandlerTizenPlugin : public flutter::Plugin {
if (std::holds_alternative<int32_t>(*arguments)) {
int permission = std::get<int32_t>(*arguments);
auto reply = result.release();
auto on_success = [reply](int status) {
reply->Success(flutter::EncodableValue(status));
auto on_success = [reply](ServiceStatus status) {
reply->Success(flutter::EncodableValue(static_cast<int>(status)));
delete reply;
};
auto on_error = [reply](const std::string &code,
const std::string &message) {
reply->Error(code, message);
delete reply;
};
service_manager_.CheckServiceStatus(permission, on_success, on_error);
service_manager_.CheckServiceStatus(
static_cast<PermissionGroup>(permission), on_success, on_error);
} else {
result->Error("MethodCall - Invalid arguments",
"arguments type of method checkServiceStatus isn't int");
Expand All @@ -65,17 +68,17 @@ class PermissionHandlerTizenPlugin : public flutter::Plugin {
if (std::holds_alternative<int32_t>(*arguments)) {
int permission = std::get<int32_t>(*arguments);
auto reply = result.release();
auto on_success = [reply](int status) {
reply->Success(flutter::EncodableValue(status));
auto on_success = [reply](PermissionStatus status) {
reply->Success(flutter::EncodableValue(static_cast<int>(status)));
delete reply;
};
auto on_error = [reply](const std::string &code,
const std::string &message) {
reply->Error(code, message);
delete reply;
};
permission_manager_.CheckPermissionStatus(permission, on_success,
on_error);
permission_manager_.CheckPermissionStatus(
static_cast<PermissionGroup>(permission), on_success, on_error);
} else {
result->Error(
"MethodCall - Invalid arguments",
Expand All @@ -84,20 +87,24 @@ class PermissionHandlerTizenPlugin : public flutter::Plugin {
} else if (method_name.compare("requestPermissions") == 0) {
const flutter::EncodableValue *arguments = method_call.arguments();
if (std::holds_alternative<flutter::EncodableList>(*arguments)) {
std::vector<int> permissions;
std::vector<PermissionGroup> permissions;
for (auto iter : std::get<flutter::EncodableList>(*arguments)) {
permissions.push_back(std::get<int32_t>(iter));
permissions.push_back(
static_cast<PermissionGroup>(std::get<int32_t>(iter)));
}
auto reply = result.release();
auto on_success = [reply](const std::map<int, int> &results) {
flutter::EncodableMap encodables;
for (auto [key, value] : results) {
encodables.emplace(flutter::EncodableValue(key),
flutter::EncodableValue(value));
}
reply->Success(flutter::EncodableValue(encodables));
delete reply;
};
auto on_success =
[reply](
const std::map<PermissionGroup, PermissionStatus> &results) {
flutter::EncodableMap encodables;
for (auto [key, value] : results) {
encodables.emplace(
flutter::EncodableValue(static_cast<int>(key)),
flutter::EncodableValue(static_cast<int>(value)));
}
reply->Success(flutter::EncodableValue(encodables));
delete reply;
};
auto on_error = [reply](const std::string &code,
const std::string &message) {
reply->Error(code, message);
Expand Down