Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support testing on multiple targets #191

Merged
merged 8 commits into from Sep 3, 2021
Merged

Support testing on multiple targets #191

merged 8 commits into from Sep 3, 2021

Conversation

HakkyuKim
Copy link
Contributor

@HakkyuKim HakkyuKim commented Aug 27, 2021 •
edited

This PR supports running integration tests on multiple targets by passing a yaml file.

Given the following recipe.yaml file,

plugins:
  audioplayers: ["wearable-5.5"]
  package_info_plus: ["wearable-5.5", "mobile-6.0"]
  wakelock: ["tv-6.0"]

running tools/run_command.py test --plugins wakelock audioplayers package_info_plus --recipe recipe.yaml outputs the following result:

SUCCEEDED: wakelock tv-6.0
SUCCEEDED: audioplayers wearable-5.5
SUCCEEDED: package_info_plus wearable-5.5
SUCCEEDED: package_info_plus mobile-6.0
All tests passed!

TODOs

  • handle error cases
  • formatting

@HakkyuKim HakkyuKim mentioned this pull request Aug 27, 2021
Closed
4 tasks
@HakkyuKim HakkyuKim marked this pull request as ready for review September 1, 2021 05:45
bbrto21
bbrto21 reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this import argparse

tools/commands/integration_test.py Outdated Show resolved Hide resolved
tools/commands/integration_test.py Outdated Show resolved Hide resolved
bbrto21
bbrto21 approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HakkyuKim
Copy link
Contributor Author

HakkyuKim commented Sep 2, 2021 •
edited

remove this import argparse

@bbrto21
Oh, I missed this comment, I removed the import. I also noticed that you can't properly import commands.command_utils as command_utils when running scripts in commands. If you're not planning to run scripts independently, I'll remove all __name__ == "__main__" from command scripts.

@bbrto21
Copy link
Contributor

bbrto21 commented Sep 2, 2021 •
edited

If you're not planning to run scripts independently, I'll remove all name == "main" from command scripts.

Well.. I had had a plan not detailed... please feel free to remove them if you want 😆

@HakkyuKim HakkyuKim merged commit 3fe58fd into flutter-tizen:master Sep 3, 2021
seungsoo47 pushed a commit to seungsoo47/plugins that referenced this pull request Sep 10, 2021
@HakkyuKim @seungsoo47
Support testing on multiple targets (flutter-tizen#191)
a36f923 
* Add recipe arg

* Return list of TestResults

* Parse and match target ids to recipe inputs

* Handle error cases and add requirements.txt

Also remove the word "server" from log messages.

* Use recipe to tell the tool about testable targets

* Apply yapf google style formatting

* Update based on review

* Remove argparse import
@HakkyuKim HakkyuKim deleted the integration-test-recipe branch December 21, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrto21 bbrto21 bbrto21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HakkyuKim @bbrto21