[video player] Add video_player package #48
Conversation
There was a problem hiding this comment.
Only white screen could be displayed on my TV 6.0 emulator:
The integration test succeeded but there were some error messages.
VMServiceFlutterDriver: Connected to Flutter application.
I/ConsoleMessage( 9868): flutter: 00:00 +0: asset videos can be initialized
E/ConsoleMessage( 9868): Invalid read in StandardCodecByteStreamReader
E/ConsoleMessage( 9868): ../../../../flutter/shell/platform/tizen/external_texture_gl.cc: DestructionTbmSurface(131) > tbm_surface_h is NULL
I/ConsoleMessage( 9868): flutter: 00:01 +1: asset videos can be played
E/ConsoleMessage( 9868): ../../../../flutter/shell/platform/tizen/external_texture_gl.cc: DestructionTbmSurface(131) > tbm_surface_h is NULL
I/ConsoleMessage( 9868): flutter: 00:02 +2: asset videos can seek
E/ConsoleMessage( 9868): ../../../../flutter/shell/platform/tizen/external_texture_gl.cc: DestructionTbmSurface(131) > tbm_surface_h is NULL
I/ConsoleMessage( 9868): flutter: 00:02 +3: asset videos can be paused
E/ConsoleMessage( 9868): ../../../../flutter/shell/platform/tizen/external_texture_gl.cc: DestructionTbmSurface(131) > tbm_surface_h is NULL
I/ConsoleMessage( 9868): flutter: 00:04 +4: asset videos test video player view with local asset
E/ConsoleMessage( 9868): ../../../../flutter/shell/platform/tizen/external_texture_gl.cc: DestructionTbmSurface(131) > tbm_surface_h is NULL
I/ConsoleMessage( 9868): flutter: 00:05 +5: (tearDownAll)
I/ConsoleMessage( 9868): flutter: 00:05 +6: All tests passed!
Stopping application instance.
| @@ -0,0 +1,15 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest package="org.tizen.video_player_tizen_example" version="1.0.0" api-version="6.0" xmlns="http://tizen.org/ns/packages"> | |||
There was a problem hiding this comment.
Isn't this plugin supported on older versions of Tizen?
There was a problem hiding this comment.
Only support tizen 5.5 and tizen 6.0 now.
There was a problem hiding this comment.
Please specify it in README.md like this:
## Supported devices
This plugin supports Tizen 5.5 or later only.
packages/video_player/pubspec.yaml
Outdated
|
|
||
| environment: | ||
| sdk: ">=2.8.0<3.0.0" | ||
| flutter: ">=1.12.13+hotfix.5 <2.0.0" |
There was a problem hiding this comment.
This needs update to be published on pub.dev.
| flutter: ">=1.12.13+hotfix.5 <2.0.0" | |
| flutter: ">=1.20.0 <2.0.0" |
There was a problem hiding this comment.
I will modify it.
|
The following exception occurs when changing the video play speed on Tizen TV 6.0 |
|
Video player plugin can't be run on TV emulator, the error is caused by the emulator. This problem is reported before. |
|
If a plugin cannot be supported on a particular platform, the reason should be clearly stated. Merging a PR into the master branch means that it's going for an official release on pub.dev. |
We will check with both emulator team and MM player team |
|
We checked with both emulator team and MM player team, they don't know how to solve it:
So, right now, we can't support tv emulator, we will send this bug to them officially. |
|
The analysis of the issue that video can't be played on TV emulator:
I added NV12 in libtbm-emulator, tbm surface can be created successfully, but then failed in the following. srcn sdk developers think NV12 format may not be supported by qemu or kernel, but they are not sure about it. mmplayer think there should be two bos, one for Y, one for UV, for NV12 format, but in libtbm-emulator, things are different, it store all YUV data in one bo, so mmplayer get failed for the second bo which is not exist in libtbm-emulator. Anyway, for now, tv emulator can't support this. |
|
Were you able to reproduce #48 (comment) and will there be any fix for it? Please add these lines at the end of each table in README.md when the tests are all done: # Table 1
| [**video_player_tizen**](packages/video_player) | [video_player](https://github.com/flutter/plugins/tree/master/packages/video_player) (1st-party) | [](https://pub.dev/packages/video_player_tizen) | No |
# Table 2
| [**video_player_tizen**](packages/video_player) | ✔️ | ✔️ | ✔️ | ❌ | API limitation | |
|
About exception occurs when changing the video play speed on Tizen TV 6.0, it's the limit of TV mmplayer. player_set_playback_rate can't set rate when the play time is last 3 senconds on TV. I can set the rate successfully when start to play video. And there is another error, mmplayer doesn't play video on a loop after set rate, I'm checking it. |
|
Video player plugin has some limitations on TV.
I will add this infomation in ReadMe. |
|
@HakkyuKim Is this error #48 (comment) by any chance related to the keyframe issue mentioned by Wanchao? Or is it a different issue? |
If seekTo is changing the currently playing frame location, then no. The issue seems to be related to:
Indeed the playback speed does change when I switch it immediately after the video starts, and fails when I switch it at the end of the video. |
|
Will we have any fix for these messages? This occurs on any of my devices. Hakkyu has reported the same error in the above. |
It caused by frame loss when playing video, we think it has no significant effect, so we keep it now. |
No description provided.