Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example app cleanup #394

Merged
merged 3 commits into from Aug 23, 2023
Merged

Example app cleanup #394

merged 3 commits into from Aug 23, 2023

Conversation

VictorUvarov
Copy link
Contributor

@VictorUvarov VictorUvarov commented Aug 22, 2023 •
edited

  • mirror local video when front facing camera
  • update video call parameters to use higher resolution and front facing camera
  • run dart format
  • update dependencies

@VictorUvarov
Example app cleanup
da2400a 
- mirror local video when front facing camera
- run dart format
- update dependencies
cloudwebrtc
cloudwebrtc approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VictorUvarov
Copy link
Contributor Author

VictorUvarov commented Aug 23, 2023 •
edited

I guess some of the dependencies require a newer version of flutter. Should I downgrade the dependencies? Or upgrade the GitHub job to use a newer flutter version?

@cloudwebrtc cloudwebrtc merged commit 6a87d71 into flutter-webrtc:master Aug 23, 2023
1 check passed
@VictorUvarov VictorUvarov deleted the format-example branch September 14, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VictorUvarov @cloudwebrtc