Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCPeerConnectionWeb's connectionState is calculated based on iceConnectionState vs connectionState #10

Closed
cterefinko opened this issue Apr 3, 2022 · 1 comment · Fixed by #14
Closed

RTCPeerConnectionWeb's connectionState is calculated based on iceConnectionState vs connectionState #10

cterefinko opened this issue Apr 3, 2022 · 1 comment · Fixed by #14

Comments

@cterefinko
Copy link

RTCPeerConnectionWeb's connectionState is updated by onIceConnectionStateChange and is calculated based on iceConnectionState. The more appropriate onConnectionStateChange and connectionState aren't exposed via dart2js (issue).

Filing this issue to tracking updating to use those once added.

The effect of using iceConnectionState is that since RTCIceConnectionState has an extra 'checking' state vs RTCPeerConnectionState, peerConnectionStateForString reports RTCPeerConnectionStateClosed for the unknown checking state.
@cterefinko cterefinko mentioned this issue Apr 5, 2022
Closed
@amantoux
Copy link
Contributor

amantoux commented Sep 1, 2022 •
edited
Loading

dart-lang/sdk#48735 is available with Flutter 3.3
I guess we can move forward on this

@amantoux amantoux mentioned this issue Sep 18, 2022
Merged
@amantoux amantoux mentioned this issue Sep 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix connectionState being incorrect amantoux/dart-webrtc
2 participants
@cterefinko @amantoux