Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCPeerConnection missing connectionState property #48735

Closed
cterefinko opened this issue Apr 3, 2022 · 3 comments
Closed

RTCPeerConnection missing connectionState property #48735

cterefinko opened this issue Apr 3, 2022 · 3 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html web-libraries Issues impacting dart:html, etc., libraries

Comments

@cterefinko
Copy link
Contributor

cterefinko commented Apr 3, 2022 •
edited

html_dart2js is missing the native js property connectionState and an onConnectionStateChange handler for RTCPeerConnection.
@cterefinko cterefinko mentioned this issue Apr 3, 2022
Closed
@lrhn lrhn added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Apr 3, 2022
@Markzipan Markzipan added web-libraries Issues impacting dart:html, etc., libraries library-html labels Apr 5, 2022
@Markzipan
Copy link
Contributor

Pinging @srujzs

@srujzs
Copy link
Contributor

srujzs commented Apr 5, 2022

I think this is possibly a simple fix, but haven't dug much into it yet. It seems like we need to add that property and create a separate static EventStreamProvider for connectionstatechange. It seems like it should be possible to workaround this with interop, however, using js_util and addEventListener.

@cterefinko
Copy link
Contributor Author

Since I'd like to to update dart-webrtc to use these, I think it'd be nice to not have to use interop.

I sent out https://dart-review.googlesource.com/c/sdk/+/240240 for review, but it was unclear to me if there was anything else that needed to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cterefinko @lrhn @Markzipan @srujzs