Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix android wrong screen capture size. #1508

Merged

Conversation

Jaemin-VIRNECT
Copy link
Contributor

When you use the android screen capture feature, it provides an incorrect capture size; in most cases, this bug may not be a significant issue. However, it becomes problematic when working with the Flutter overlay view. (iOS works okay.)

The log is shown below.
2023-12-27 14:56:27.549 14766-14766 FlutterWebRTCPlugin D OrientationAwareScreenCapturer.startCapture: 1080x2122@30
Test Device: Galaxy S20 Ultra 5G
Device screen size: 1080x2316

Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cloudwebrtc cloudwebrtc merged commit 0a5bc58 into flutter-webrtc:main Dec 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants