Fix handling of unimplemented method #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladimirBrejcha
pushed a commit
to sergeynekrasov8430/flutter-webrtc
that referenced
this pull request
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1504
Fixes #1525
This fixes an issue in the handling of unimplemented methods.
Because all unimplemented methods result in a call to
HandleFrameCryptorMethodCall, which contains amoveon theresultpointer, if we later try to callresult.NotImplementedit fails becauseresultpointer was nullified during this moveflutter-webrtc/common/cpp/src/flutter_webrtc.cc
Line 1244 in 81d3d84
This fixes the issue by moving
resultback out of the function call in the case ofHandleFrameCryptorMethodCallfails. Not sure how we feel about using out parameters like this, but this felt like the simplest fix to me. Open to suggestions for alternatives!