Update to latest Dart version, fix deprecations. #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
changed the title
gspencergoog
force-pushed
the
update_dart
branch
3 times, most recently
from
9e1740e
to
daf60fc
Compare
8 tasks
gspencergoog
force-pushed
the
update_dart
branch
4 times, most recently
from
28bf1d2
to
1a44a6d
Compare
domesticmouse
approved these changes
May 25, 2023
This was referenced May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the Dart version in the pubspecs to 3.0, reformats the code, and fixes any analyzer errors that occured with that. This largely replaces #216, which I started with.
This also fixes deprecation warnings for using the singleton flutter window (
ui.window). Where possible, it uses thePlatformDispatcherproperty requested, but for devicePixelRatio, it uses thePlatformDispatcher.instance.implicitView, defaulting to 1.0 if the implicit view isn't built. This is because most usages didn't have access to a context to fetch the current view from. We might want to reorganize things to make this possible in the future.Related Issues
Tests