Update sysroot_ld_path.py for Python3 #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3, subprocess.check_output returns an encoding-independent byte array. If passed universal_newlines=True, both Python 2 and 3 decode and return a UTF-8 string. Issue: flutter/flutter#83043
chinmaygarde
approved these changes
Jun 4, 2021
|
I noticed that Python 2 appears to have been removed from my gLinux machine overnight. Eons ago I signed up to be on the testing channel, so perhaps this is finally on the way? |
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Jun 4, 2021
This picks up: flutter/buildroot#461: Update sysroot_ld_path.py for Python3 Issue: flutter/flutter#83043
This was referenced Jun 4, 2021
cbracken
added a commit
to flutter/engine
that referenced
this pull request
Jun 5, 2021
This picks up: flutter/buildroot#461: Update sysroot_ld_path.py for Python3 Issue: flutter/flutter#83043
richkadel
pushed a commit
to richkadel/buildroot
that referenced
this pull request
Jun 25, 2021
In Python 3, subprocess.check_output returns an encoding-independent byte array. If passed universal_newlines=True, both Python 2 and 3 decode and return a UTF-8 string. Issue: flutter/flutter#83043
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
This picks up: flutter/buildroot#461: Update sysroot_ld_path.py for Python3 Issue: flutter/flutter#83043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3, subprocess.check_output returns an encoding-independent
byte array. If passed universal_newlines=True, both Python 2 and 3
decode and return a UTF-8 string.
Issue: flutter/flutter#83043