Python 3 migration required for Android builds #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates all Python scripts required to build Android targets to be
Python 3.x compatible.
Main changes:
* Communication with processes now returns bytestreams by default. By
specifying universal_newlines=True, these streams are decoded as UTF-8.
* md5.update() takes a bytes type, but strings are now utf-8 by default.
We call string.encode('utf-8') convert to bytes.
* print now uses function syntax
Issue: flutter/flutter#83043
14 tasks
jason-simmons
approved these changes
Jun 5, 2021
richkadel
pushed a commit
to richkadel/buildroot
that referenced
this pull request
Jun 25, 2021
This migrates all Python scripts required to build Android targets to be
Python 3.x compatible.
Main changes:
* Communication with processes now returns bytestreams by default. By
specifying universal_newlines=True, these streams are decoded as UTF-8.
* md5.update() takes a bytes type, but strings are now utf-8 by default.
We call string.encode('utf-8') convert to bytes.
* print now uses function syntax
Issue: flutter/flutter#83043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates all Python scripts required to build Android targets to be
Python 3.x compatible.
Main changes:
specifying universal_newlines=True, these streams are decoded as UTF-8.
We call string.encode('utf-8') convert to bytes.
Issue: flutter/flutter#83043