Replace gyp win_tool.py with tool_wrapper.py #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jul 30, 2021
win_tool.py is incompatible with Python 3. This ports Chromium's tool_wrapper.py to our buildroot, but doesn't port their full, updated resource compiler (rc) toolchain. Chromium moved to a model where they wrap rc in an rc.py script and support resource compilation on Win, Mac, and Linux. This adds an additional CIPD dependency that we can avoid. Instead, this ports the ExecRcWrapper implementation from gyp's win_tool.py, with fixes for Python 3. Upstream source: https://chromium.googlesource.com/chromium/src/+/refs/heads/main/build/toolchain/win Replaces gyp win_tool.py: https://chromium.googlesource.com/external/gyp.git/+/refs/heads/master/pylib/gyp/win_tool.py Issue: flutter/flutter#83043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
win_tool.py is incompatible with Python 3. This ports Chromium's
tool_wrapper.py to our buildroot, but doesn't port their full, updated
resource compiler (rc) toolchain.
Chromium moved to a model where they wrap rc in an rc.py script and
support resource compilation on Win, Mac, and Linux. This adds an
additional CIPD dependency that we can avoid. Instead, this ports the
ExecRcWrapper implementation from gyp's win_tool.py, with fixes for
Python 3.
Upstream source:
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/build/toolchain/win
Replaces gyp win_tool.py:
https://chromium.googlesource.com/external/gyp.git/+/refs/heads/master/pylib/gyp/win_tool.py
Issue: flutter/flutter#83043