Update gn_helpers.py from upstream #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates our ToGNString implementation to match the Chromium version at version 4e21091c52ffc65be4df7839cc2e86575237e968 of the upstream repo https://chromium.googlesource.com/chromium/src/+/refs/heads/main/build/gn_helpers.py Also switches to absolute (buildroot relative) paths for invocations of vs_toolchain.py.
chinmaygarde
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our ToGNString implementation to match the Chromium version at
version 4e21091c52ffc65be4df7839cc2e86575237e968 of the upstream repo
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/build/gn_helpers.py
Also switches to absolute (buildroot relative) paths for invocations of
vs_toolchain.py.
This fixes a path resolution issue when invoking vs_toolchain.py wherein the
path would get concatenated onto the end of the buildroot path rather
than getting correctly resolved.
Issue: flutter/flutter#83043