Add comment on arm64_apilevel26 Android GN toolchain #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Sep 5, 2023
| # This toolchain should only be used to build the target | ||
| # //third_party/vulkan_validation_layers. This is because vulkan validation | ||
| # layers requires API level >= 26, but Flutter officially supports down to API | ||
| # level 22, which is the default value of the android_api_level argument. |
There was a problem hiding this comment.
might want to mention something about how this is safe only because of runtime checks before loading the dynamic library
There was a problem hiding this comment.
Yeah good point. Adding a comment to that effect in flutter/engine#45467.
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Sep 5, 2023
Companion comment to the one in flutter/buildroot#761
zanderso
added a commit
to flutter/engine
that referenced
this pull request
Sep 6, 2023
Just to pick up comments added in flutter/buildroot#761
zanderso
added a commit
to flutter/engine
that referenced
this pull request
Sep 6, 2023
Just to pick up comments added in flutter/buildroot#761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have had this in #759.