Add cpu dimension support when parsing ci yaml #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,7 @@ class Target { | |||
| static const List<String> iosPlatforms = <String>['mac_ios', 'mac_ios32']; | |||
|
|
|||
| /// Dimension list defined in .ci.yaml. | |||
| static List<String> dimensionList = <String>['os', 'device_os', 'device_type', 'mac_model', 'cores']; | |||
| static List<String> dimensionList = <String>['os', 'device_os', 'device_type', 'mac_model', 'cores', 'cpu']; | |||
jmagman
approved these changes
Apr 14, 2022
CaseyHillers
approved these changes
Apr 14, 2022
keyonghan
added
the
waiting for tree to go green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
mac_model, it is recommended to usecpu+os. This PR addscpudimension support defined in .ci.yaml config, which will help validate changes in pre-submit.Related: https://flutter-review.googlesource.com/c/infra/+/29061
context: flutter/flutter#101871, flutter/flutter#101861