Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different methods for merging a pull request via autosubmit and revert #2442

Closed
wants to merge 46 commits into from

Conversation

ricardoamador
Copy link
Contributor

This change will allow users to specify the merge strategy type by adding a comment to the open pull request in the format of:
'@autosubmit:merge',
'@autosubmit:rebase',
or
'@autosubmit:squash'.
If this comment is present the chosen merge strategy will be used to merge the pull request.
The default merge strategy that will be used is squash which is what is currently used to merge a pull request via the autosubmit bot.

List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#118361
Fixes flutter/flutter#114557

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ricardoamador and others added 30 commits October 7, 2022 09:45
Copy link
Contributor

@yusuf-goog yusuf-goog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments/nits, otherwise LGTM.

auto_submit/lib/service/validation_service.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@yusuf-goog yusuf-goog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change reqeust

auto_submit/lib/service/validation_service.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@nehalvpatel nehalvpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ricardoamador
Copy link
Contributor Author

Abandoning this because the commit history for this branch is not in a good state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants