Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codesign] remove metadata files for now #2758

Merged
merged 3 commits into from
May 16, 2023

Conversation

XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented May 16, 2023

Remove codesign metadata after parsing them.

Context: fix flutter/flutter#126705 by removing codesign metadata after parsing them. When flutter/flutter#126875 becomes ready, we could add back codesign metadata inside engine zips?

Sorry for the delay, was busy landing different cps during the day

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit about removing try - finally, otherwise LGTM

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit about removing try - finally, otherwise LGTM

Co-authored-by: Christopher Fujino <fujino@google.com>
@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App. label May 16, 2023
@auto-submit auto-submit bot merged commit 0fc0cd5 into flutter:main May 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
2 participants