Updated dashboard: wired down Material2 dependency #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
CaseyHillers
approved these changes
Jun 13, 2023
CaseyHillers
added
the
autosubmit
HansMuller
added a commit
to flutter/tests
that referenced
this pull request
Jun 13, 2023
Updated the cocoon hash to bring in changes that will allow ThemeData.useMaterial3's default to become true. See flutter/cocoon#2837 --------- Co-authored-by: Christopher Fujino <fujino@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for the change to the default value of
ThemeData.useMaterial3coming in flutter/flutter#127064. Currently the dashboard's tests depend on the UI being configured for Material2. While we're undergoing this transition, changed the dashboard's MaterialApp and its tests to specifyuseMaterial3: false.