Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reviewing history for the logging screen #29

Open
devoncarew opened this issue Sep 26, 2018 · 4 comments
Open

Support reviewing history for the logging screen #29

devoncarew opened this issue Sep 26, 2018 · 4 comments
Milestone

Comments

@devoncarew
Copy link
Member

There's currently no visual change in the logging page when we lose the device connection. We should make sure there is (put a subtle transparent overlay on the logging items?), and do something similar on the other pages as well.

@kenzieschmoll
Copy link
Member

The page footer says "no device connected". Upon losing connection, a toast-like dialog is also shown.

@kenzieschmoll
Copy link
Member

Actually perhaps we should show this UI when we lose device connection? This would be more obvious than the message in the footer.
Screen Shot 2019-03-19 at 3 55 46 PM

@kenzieschmoll kenzieschmoll reopened this Mar 19, 2019
@kenzieschmoll kenzieschmoll changed the title when we lose connection to the device, make a visual change in the logging page Consider showing connect UI upon losing device connection Mar 19, 2019
@jacob314 jacob314 added the good first issue Good for newcomers label Jul 16, 2019
@kenzieschmoll kenzieschmoll added this to the Backlog milestone Jul 23, 2019
@devoncarew
Copy link
Member Author

We do this now, however, users loose all info about the app session (we switch to the connect screen and remove all the other screens). We may want to adjust this as being able to go back and look at data for the app is useful (memory usage? logs info? the timeline info for the last few frames?).

@kenzieschmoll kenzieschmoll changed the title Consider showing connect UI upon losing device connection Switch to offline state without losing current data upon losing device connection May 26, 2020
@kenzieschmoll kenzieschmoll changed the title Switch to offline state without losing current data upon losing device connection Support reviewing history for the logging screen May 26, 2023
@kenzieschmoll
Copy link
Member

kenzieschmoll commented May 26, 2023

This can be supported by a combination of:

  1. implementing support for loading offline data for the logging screen: Enable offline support for all DevTools screens #4470
  2. ensuring the logging screen supports reviewing history on disconnect - see this commit for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants