-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devtool_extension: Would it make sense to have the extension's sources directly in the devtool/extension folder? #6597
Comments
This is an interesting proposal. @jonasfj what are your thoughts on this configuration? Would it be possible to have a The one concern I have here is that it seems like it may be more likely that a package author publishes a non-release build of their extension because they do not have to run the |
On the flip side, I personally use a custom |
Honestly, I would suggest including the sources for the flutter app, unless it's huge, just because it would make the app more complete.
Don't get me wrong I love this extension stuff, but the number of people who are going to publish extensions is always going to be a very small minority of the people who publish packages. I don't think it makes sense to customize the I'd suggest to putting a script for publishing in Or recommend that devtool extension authors add a dev_dependency on a package you own, and put utility functions into that package. Example
That would be one way where, you can easily give commands and structure to extension authors. |
I'm aware that modifying the pub commands isn't going to be that useful. For example someone may want to write a reusable Github Action for continuous deployment of packages, and would like to support deploying packages with extensions too. The various existing samples around setting up extensions would require extra configuration for such a Gtihub Action to know how to deploy packages with devtool extensions. |
I drafted a proposal for something like local-hooks in dart-lang/pub#4058 I don't know if this is a good idea, maybe this proposal is too generic. Maybe, the whole concept is too complicated. Most packages probably won't need it. |
Hello!
Currently the recommendation seems to be to have:
I was wondering if there would be any possible issue with instead having:
where
.pubignore
is:This would be easier to manage as:
my_package_extension/build
tomy_package/extension/devtool/build
my_package
needs to be re-released. Release tools could also more easily recreate thatbuild
directory (as they would have access to the source).The text was updated successfully, but these errors were encountered: