Do not clear FlutterJNI state when a FlutterView is detached #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an app is using retainFlutterNativeView or a plugin wants to keep the FlutterNativeView active, then the FlutterNativeView should not drop its handle to the corresponding native platform view. Fixes flutter/flutter#26931
matthew-carroll
approved these changes
Feb 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 26, 2019
flutter/engine@f730639...1d0615a git log f730639..1d0615a --no-merges --oneline 1d0615a libtxt: remove a debug log message in ComputeStrut (flutter/engine#7953) fd6c3fc Do not clear FlutterJNI state when a FlutterView is detached (flutter/engine#7929) dff323d Roll src/third_party/skia 507158f88d4d..0b2c05470bab (19 commits) (flutter/engine#7952) 5fcc6ac Roll src/third_party/skia 478d7d46f8d7..507158f88d4d (1 commits) (flutter/engine#7949) 6e1f0f0 Roll src/third_party/skia 5bbd02d6bb3d..478d7d46f8d7 (1 commits) (flutter/engine#7948) 9f6b297 Roll src/third_party/skia e1636a4b56aa..5bbd02d6bb3d (1 commits) (flutter/engine#7944) f2489c1 Correct FlutterSemanticsNode member name style (flutter/engine#7942) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app is using retainFlutterNativeView or a plugin wants to keep the
FlutterNativeView active, then the FlutterNativeView should not drop its
handle to the corresponding native platform view.
Fixes flutter/flutter#26931