Adds a platfromViewId to SemanticsNode #8055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
commented
Mar 6, 2019
10 tasks
goderbauer
force-pushed
the
platformViewId
branch
from
8014164
to
53c40e5
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 11, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 12, 2019
flutter/engine@a71609f...56d8634 git log a71609f..56d8634 --no-merges --oneline 56d8634 Improve shadow doc in PhysicalShapeLayer (flutter/engine#8114) bd0f908 Adds a platfromViewId to SemanticsNode (flutter/engine#8055) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit c5b176f.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit c5b176f.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Oct 25, 2019
This exposes platform_view_id on the embedder API's FlutterSemanticNode. In bd0f908 (flutter#8055), platformViewId was added to SemanticsNode. This field is non-zero when the SemanticsNode represents a platform view and is typically used by embedders as a means of identifying locations where a platform view's 'native' accessibility tree should be injected into the platform-specific accessibility tree constructed by the embedder. Due to the intended use of this field, the Flutter framework is meant to enforce that this node has a child count of zero.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Oct 25, 2019
This exposes platform_view_id on the embedder API's FlutterSemanticNode. In bd0f908 (flutter#8055), platformViewId was added to SemanticsNode. This field is non-zero when the SemanticsNode represents a platform view and is typically used by embedders as a means of identifying locations where a platform view's 'native' accessibility tree should be injected into the platform-specific accessibility tree constructed by the embedder. Due to the intended use of this field, the Flutter framework is meant to enforce that this node has a child count of zero.
cbracken
added a commit
that referenced
this pull request
Oct 25, 2019
This exposes platform_view_id on the embedder API's FlutterSemanticNode. In bd0f908 (#8055), platformViewId was added to SemanticsNode. This field is non-zero when the SemanticsNode represents a platform view and is typically used by embedders as a means of identifying locations where a platform view's 'native' accessibility tree should be injected into the platform-specific accessibility tree constructed by the embedder. Due to the intended use of this field, the Flutter framework is meant to enforce that this node has a child count of zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Framework-side changes to follow.