Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #8339

Merged
merged 1 commit into from
Mar 30, 2019
Merged

Fix typos #8339

merged 1 commit into from
Mar 30, 2019

Conversation

goderbauer
Copy link
Member

Courtesy of google's "CommonTypos" analysis.

Courtesy of google's "CommonTypos" analysis.
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm_hanko

@cbracken
Copy link
Member

cbracken commented Mar 28, 2019

Can we have this presubmit on the engine too?

Oh I see, I assume this is from the internal roll? So... no then. :(

@goderbauer
Copy link
Member Author

Yeah, it's from the internal roll.

@goderbauer goderbauer merged commit 5e124ff into flutter:master Mar 30, 2019
@goderbauer goderbauer deleted the typofixes branch March 30, 2019 00:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 30, 2019
flutter/engine@ca7623e...b75472c

git log ca7623e..b75472c --no-merges --oneline
b75472c Add missing import to functional for Windows. (flutter/engine#8382)
9d71675 Ensure OpacityLayer to have a single child (flutter/engine#8362)
131cc62 Allow native entrypoint registration for runtime unittests. (flutter/engine#8379)
5e124ff Fix typos (flutter/engine#8339)
972afdc Allow running runtime_unittests in AOT mode. (flutter/engine#8375)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
RBogie pushed a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
Courtesy of google's "CommonTypos" analysis.
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants